[Bugs] #1742 UNSP: palettes of buddies in the neighborhood don't update

[Sugar Labs Bugs]

#1742: palettes of buddies in the neighborhood don't update
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  tomeu            
        Type:  defect                     |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.88             
   Component:  sugar                      |        Version:  Git as of bugdate
    Severity:  Blocker                    |       Keywords:  sugar-love       
Status_field:  New                        |   Distribution:                   
   Seeta_dev:  Anurag                     |  
------------------------------------------+---------------------------------
Changes (by alsroot):

  * severity:  Minor => Blocker


Comment:

 I've set Severity to Blocker because commit (it is in 0.90.2)
 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/356641c332d6cc889b265dfc29598004cf37763c
 introduced a regression.

 |TestCase|
 * switch to journal
 * open entry palette
 * choose "Vew Details"
 * nothing happened

 The problem part is:
 {{{
 diff --git a/src/sugar/graphics/palettewindow.py
 b/src/sugar/graphics/palettewindow.py
 index f51c938..449c77f 100644
 --- a/src/sugar/graphics/palettewindow.py
 +++ b/src/sugar/graphics/palettewindow.py
 @@ -642,7 +642,6 @@ class Invoker(gobject.GObject):
          if self._palette is not None:
              self._palette.popdown(immediate=True)
              self._palette.props.invoker = None
 -            self._palette.destroy()

          self._palette = palette
 }}}

 This is because on popdown, palette is being destroyed but Journal sends
 envet for Palette object, thus signal never be processed (maybe it works
 in some cases but I guess it is indeterminate behaviour).

 In fact, it might be fixed in Journal but do we need destroy() call.
 afaik, gc will do this work but after that all signals will be delivered.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1742#comment:12>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system