[Bugs] #1976 UNSP: School server registration works differently on XO

[Sugar Labs Bugs]

#1976: School server registration works differently on XO
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  timClicks        
        Type:  defect                     |         Status:  reopened         
    Priority:  Unspecified by Maintainer  |      Milestone:  0.90             
   Component:  sugar                      |        Version:  Git as of bugdate
    Severity:  Minor                      |     Resolution:                   
    Keywords:  r!                         |   Status_field:  New              
Distribution:                             |      Seeta_dev:  unassigned       
------------------------------------------+---------------------------------

Comment(by martin.langhoff):

 Thanks for looking into this! I disagree with the fix, however.

 The patch is bogus -- there was bogus logic in the non-XO codepath, and
 this patch promotes the bogosity to all the cases.

 Here is how I believe this comes to happen: when we are on a non-XO, we
 want to generate synthetic SN/UUID pars, and to store them permanently, so
 we always use the same SN/UUID in the future, even if the registration
 fails. There is _no_ reason to try save a jabber server, other than
 perhaps making store_identifiers() happy.

 The old code has several problems

  * On non-XO, it always creates an SN/UUID pair
  * On non-XO, it saves a bogus jabber server before even trying to
 register

 I am attaching an untested, draft patch trying to explain what I mean. I
 am a bit confused by SN/UUID being kept in something other than gconf.
 Should we consolidate these values into gconf?

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1976#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system