[Bugs] #1673 HIGH: discard network history does nothing

[Sugar Labs Bugs]

#1673: discard network history does nothing
-----------------------+----------------------------------------------------
    Reporter:  quozl   |          Owner:  tomeu            
        Type:  defect  |         Status:  new              
    Priority:  High    |      Milestone:  0.88.x           
   Component:  sugar   |        Version:  Git as of bugdate
    Severity:  Minor   |       Keywords:                   
Distribution:          |   Status_field:  New              
-----------------------+----------------------------------------------------
Changes (by quozl):

  * keywords:  r+ =>


Comment:

 Replying to [comment:11 tomeu]:
 > These seem like should be private? (leading underscore)

 Fixed.

 > Shouldn't we use get_settings() so we can be sure _nm_settings has been
 initialized without having to read too much code?

 Fixed.

 > This patch is r+'ed based the above petty issues are addressed, but
 please split it up in several commits, so we have one commit message per
 discrete change.

 I was unable to determine a suitable split point.

 Replying to [comment:12 tomeu]:
 > ... the code in _disconnect_activate_cb makes several dbus sync calls
 ...

 So does the existing code, in many places.  My patch does not and is not
 intended to address this existing design issue.  I could not find this
 dbus sync issue described in any other ticket.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1673#comment:13>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system