[Bugs] #1673 HIGH: discard network history does nothing

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Tue May 11 11:02:11 EDT 2010


#1673: discard network history does nothing
-----------------------+----------------------------------------------------
    Reporter:  quozl   |          Owner:  tomeu            
        Type:  defect  |         Status:  new              
    Priority:  High    |      Milestone:  0.88.x           
   Component:  sugar   |        Version:  Git as of bugdate
    Severity:  Minor   |       Keywords:  r+               
Distribution:          |   Status_field:  New              
-----------------------+----------------------------------------------------
Changes (by tomeu):

  * keywords:  r? => r+


Comment:

 +def get_wifi_connections_path():
 ...
 + def create_wifi_connections(config_path):

 These seem like should be private? (leading underscore)

 +    _nm_settings.clear_wifi_connections()

 Shouldn't we use get_settings() so we can be sure _nm_settings has been
 initialized without having to read too much code?

 This patch is r+'ed based the above petty issues are addressed, but please
 split it up in several commits, so we have one commit message per discrete
 change.

 Also, please create an user in gitorious so you can push your own patches.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1673#comment:11>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list