[Bugs] #1765 UNSP: Changes to a Journal entries metadata are wiped if activity is still open (0.84)

[Sugar Labs Bugs]

#1765: Changes to a Journal entries metadata are wiped if activity is still open
(0.84)
------------------------------------------+---------------------------------
    Reporter:  erikos                     |          Owner:  sayamindu  
        Type:  defect                     |         Status:  reopened   
    Priority:  Unspecified by Maintainer  |      Milestone:  0.84       
   Component:  sugar-toolkit              |        Version:  0.84.x     
    Severity:  Critical                   |     Resolution:             
    Keywords:  r+                         |   Distribution:  Unspecified
Status_field:  New                        |  
------------------------------------------+---------------------------------
Changes (by sayamindu):

  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 There is a small problem with the patch. We need to set
 self._update_signal_match = None before calling set_object_id().
 {{{
 diff --git a/src/sugar/datastore/datastore.py
 b/src/sugar/datastore/datastore.py
 index 6ff10de..7aa4d15 100644
 --- a/src/sugar/datastore/datastore.py
 +++ b/src/sugar/datastore/datastore.py
 @@ -109,12 +109,12 @@ class DSMetadata(gobject.GObject):

  class DSObject(object):
      def __init__(self, object_id, metadata=None, file_path=None):
 +        self._update_signal_match = None
          self.set_object_id(object_id)
          self._metadata = metadata
          self._file_path = file_path
          self._destroyed = False
          self._owns_file = False
 -        self._update_signal_match = None

      def get_object_id(self):
          return self._object_id
 }}}

-- 
Ticket URL: <https://bugs.sugarlabs.org/ticket/1765#comment:6>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system