[Bugs] #1853 UNSP: Redunant code /jarabe/view/viewsource.py

[Sugar Labs Bugs]

#1853: Redunant code /jarabe/view/viewsource.py
------------------------------------------+---------------------------------
    Reporter:  timclicks                  |          Owner:  tomeu                      
        Type:  defect                     |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar                      |        Version:  Git as of bugdate          
    Severity:  Trivial                    |       Keywords:                             
Distribution:  Unspecified                |   Status_field:  Unconfirmed                
------------------------------------------+---------------------------------
 Toolbarstop, a gtk.ToolButton, had its show() method called twice. Patch
 removes the first one, which is called before the stop has been inserted
 into the toolbar. Have manually tested.

 Output of git format-patch:

 {{{
 From 5cd8085667d2d60cbf6a8f6d0987bd1458dc99df Mon Sep 17 00:00:00 2001
 From: timClicks <paperless at timmcnamara.co.nz>
 Date: Sun, 21 Mar 2010 12:39:15 +1300
 Subject: [PATCH] Removed redundancy

 Toolbarstop, a gtk.ToolButton, had its show() method called
 twice. Removed the first one.
 ---
  src/jarabe/view/viewsource.py |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

 diff --git a/src/jarabe/view/viewsource.py b/src/jarabe/view/viewsource.py
 index 9905713..290df18 100644
 --- a/src/jarabe/view/viewsource.py
 +++ b/src/jarabe/view/viewsource.py
 @@ -309,7 +309,6 @@ class Toolbar(gtk.Toolbar):
          stop = ToolButton(icon_name='dialog-cancel')
          stop.set_tooltip(_('Close'))
          stop.connect('clicked', self.__stop_clicked_cb)
 -        stop.show()
          self.insert(stop, -1)
          stop.show()

 --
 1.6.3.3

 }}}

-- 
Ticket URL: <https://bugs.sugarlabs.org/ticket/1853>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system