[Bugs] #2094 UNSP: hide mesh device icon when inactive

[Sugar Labs Bugs]

#2094: hide mesh device icon when inactive
------------------------------------------+---------------------------------
    Reporter:  dsd                        |          Owner:  tomeu                      
        Type:  defect                     |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar                      |        Version:  Unspecified                
    Severity:  Unspecified                |       Keywords:  r+                         
Distribution:  Unspecified                |   Status_field:  Unconfirmed                
------------------------------------------+---------------------------------
Changes (by tomeu):

  * keywords:  r? => r+


Comment:

 +        del self._device_view
 +        self._device_view = None

 Is that del really needed?

 +        logging.error('Error getting the device properties: %s', err)

 May be better to raise an exception so we have the traceback.

 +        if state >= network.DEVICE_STATE_PREPARE \
 +           and state <= network.DEVICE_STATE_ACTIVATED:

 I personally think we should treat that as an enum and don't assume
 anything about the integer values of the enum values, but I see we are
 already doing it somewhere else.

 Please push when you think these concerns have been addressed.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2094#comment:1>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system