[Bugs] #230 HIGH: No mesh support under 83.x (joyride 2631)

[Sugar Labs Bugs]

#230: No mesh support under 83.x (joyride 2631)
----------------------------+-----------------------------------------------
    Reporter:  garycmartin  |          Owner:  tomeu   
        Type:  enhancement  |         Status:  assigned
    Priority:  High         |      Milestone:  0.88    
   Component:  sugar        |        Version:  0.83.x  
    Severity:  Major        |       Keywords:  r?      
Distribution:  Unspecified  |   Status_field:  New     
----------------------------+-----------------------------------------------
Changes (by dsd):

  * keywords:  r! => r?


Comment:

 most of your comments apply equally to existing code found in those files,
 but i've made the changes for most of them.

 Replying to [comment:11 tomeu]:
 > We really don't want to log anything?

 No - the connections might have changed state during the loop

 > Would be better to create the palette when it's needed (grep the code
 for "def create_palette"), in order to save memory.

 I had a quick look and couldn't figure this out.  The other 3 classes in
 this file create the palette the same way.

 > Wonder if wouldn't make sense to accept the local translation of mesh
 for helping locating the mesh icons.

 it would be nice but I haven't bothered to implement this this time
 around. The behaviour that I have implemented matches 0.82.

 > Wouldn't be better to just name jarabe.model.network.OlpcMesh as
 OlpcMeshSettings?

 this would break the naming convention of classes in that file

 > Is it a stack or a queue?

 its a connection queue implemented as a stack

 I couldn't see any opportunities to divide functions up without impacting
 code readability.

 sorry that I'm a bit strapped for time..here's an updated patch

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/230#comment:12>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system