[Bugs] #1749 UNSP: mark legacy clients as valid

[Sugar Labs Bugs]

#1749: mark legacy clients as valid
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  sascha_silbe               
        Type:  defect                     |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar-presence-service     |        Version:  Git as of bugdate          
    Severity:  Major                      |       Keywords:  r?                         
Distribution:  Unspecified                |   Status_field:  Assigned                   
------------------------------------------+---------------------------------
 From src/buddy.py:
 {{{
             # Validity starts off False, and becomes True when the buddy
             # either has, or has tried and failed to get, a color, a nick
             # and a key.
 }}}

 Currently the "has tried and failed to get" part isn't true because
 get_properties() doesn't tell Buddy about the failed attempt. The attached
 patch fixes that.
 Impact: Legacy (i.e. non-Sugar) clients that are in the users Jabber
 roster (either via shared roster or added manually outside of Sugar) and
 are online will be shown in the Neighborhood (and in the groups view once
 added as friend). Currently they are shown in the owners color, but that's
 a separate bug.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1749>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system