[Bugs] #1652 URGE: Add Connection Information to 3G (GSM) Modem Support

[Sugar Labs Bugs]

#1652: Add Connection Information to 3G (GSM) Modem Support
------------------------------------+---------------------------------------
    Reporter:  Dcastelo             |          Owner:  Dcastelo         
        Type:  enhancement          |         Status:  reopened         
    Priority:  Urgent               |      Milestone:  0.88             
   Component:  sugar                |        Version:  Git as of bugdate
    Severity:  Major                |     Resolution:                   
    Keywords:  3G GSM modem usb r+  |   Distribution:  Fedora           
Status_field:  Assigned             |  
------------------------------------+---------------------------------------
Changes (by erikos):

  * status:  closed => reopened
  * severity:  Unspecified => Major
  * priority:  Unspecified by Maintainer => Urgent
  * version:  Unspecified => Git as of bugdate
  * milestone:  Unspecified by Release Team => 0.88
  * resolution:  fixed =>
  * status_field:  Unconfirmed => Assigned


Comment:

 Hi Daniel, I have a few suggestions from Tomeu to the current code we
 landed it git yesterday. Can you give us another patch with these fixed?

 {{{
 -        elif state is network.DEVICE_STATE_DISCONNECTED:
 +        if state is network.DEVICE_STATE_DISCONNECTED:

 Why replacing that elif for if?

 +                self._connection_time_handler = gobject.timeout_add(1000,
 self.__connection_timecount_cb)

 All timeouts should be started with gobject.timeout_add_seconds, to
 increase the idle time between timeouts
 Ideally, this timeout would be only active while the palette is visible
 and the palette would update its stats on popup (there's a signal for
 that)

 +        self._palette._data_label.set_text(_("Data sent %d kb / received
 %d kb") % (out_kbytes ,in_kbytes))

 kb doesn't mean kilobits? Maybe better KB? Watch out the spacing around
 the comma

 +        self._palette._conn_time_label.set_text(_("Connection time ") +
 connection_time.strftime('%H : %M : %S'))

 Guess that the time format should be translatable, to account for
 different formats across countries
 }}}

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1652#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system