[Bugs] #1684 UNSP: Add support for an alternate localedir

[Sugar Labs Bugs]

#1684: Add support for an alternate localedir
------------------------------------------+---------------------------------
    Reporter:  sayamindu                  |          Owner:  erikos     
        Type:  enhancement                |         Status:  new        
    Priority:  Unspecified by Maintainer  |      Milestone:  0.88       
   Component:  sugar-toolkit              |        Version:  Unspecified
    Severity:  Unspecified                |       Keywords:  r!         
Distribution:  Unspecified                |   Status_field:  Unconfirmed
------------------------------------------+---------------------------------
Changes (by erikos):

  * keywords:  r? => r!


Comment:

 About the de_DE and de confusion: I am not sure (testing is a few days
 ago) it worked for me with this error. Please verify that.

 Style: There are still quite some abbreviations in the code. And sometimes
 you do 'filepath' and then magic_number. Please use the underscore format
 consistently. As well the argument 'fmt' is not very descriptive.

 Comments: The comment for get_locale_path should contain the return value.
 You might want to add a comment for the module, too. And as this is inner
 API we should reflect that in some way (not sure yet how to do that).

 {{{
 # Fancy way to sort the dictionary by value
 }}}
 I fear this is redundant information :) The code should be self
 explanatory if possible. For example you could assign the outcome of
 {{{
 sorted(candidate_dirs.iteritems(), key=lambda (k, v): (v, k),
 reverse=True)
 }}}
 to variables and return that. In addition with the comment in the
 docstring this would already make it a lot clearer.

 Thanks!

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1684#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system