[Bugs] #1684 UNSP: Add support for an alternate localedir

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Mon Feb 1 12:11:03 EST 2010


#1684: Add support for an alternate localedir
------------------------------------------+---------------------------------
    Reporter:  sayamindu                  |          Owner:  erikos     
        Type:  enhancement                |         Status:  new        
    Priority:  Unspecified by Maintainer  |      Milestone:  0.88       
   Component:  sugar-toolkit              |        Version:  Unspecified
    Severity:  Unspecified                |       Keywords:  r!         
Distribution:  Unspecified                |   Status_field:  Unconfirmed
------------------------------------------+---------------------------------
Changes (by erikos):

  * keywords:  r? => r!


Comment:

 This is the path that gets generated by the script:
 {{{
 /home/erikos/Activities/Memorize.activity/locale/de_DE/LC_MESSAGES/org.laptop.Memorize.mo
 }}}

 However on my system the path is:
 {{{
 /home/erikos/Activities/Memorize.activity/locale/de/LC_MESSAGES/org.laptop.Memorize.mo
 }}}


 This should be an 'and'
 {{{
 if packdir is not None or packdir is not '':
 }}}


 Smaller ones:

 packdir - can you change that member to be packagedir (abbreviations in
 general)

 Watch out for spaces:
 {{{
 ValueError ('Could not find revision date')
 }}}

 I would try to avoid such constructs if possible. At least they are easier
 to read when splitting them in a few lines.
 {{{
 sorted(candidate_dirs.iteritems(), key=lambda (k, v): (v, k), \
         reverse = True)[0][0]
 }}}

 Unused variables should be with trailing underscore.
 {{{
 version_, numofstrings = _readbin(handle, fmt, 8)
 }}}
 Please run scripts/data/pep8.py and pylint (included in jhbuild). More:
 http://wiki.sugarlabs.org/go/Development_Team/Code_guidelines#Tools

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1684#comment:3>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list