[Bugs] #2208 UNSP: time data ... does not match format '%Y-%m-%dT%H:%M:%S'

[Sugar Labs Bugs]

#2208: time data ... does not match format '%Y-%m-%dT%H:%M:%S'
------------------------------------------+---------------------------------
    Reporter:  carrott                    |          Owner:  alsroot                    
        Type:  defect                     |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  journal                    |        Version:  0.84.x                     
    Severity:  Major                      |       Keywords:  dextrose r?                
Distribution:  Fedora                     |   Status_field:  Unconfirmed                
------------------------------------------+---------------------------------

Comment(by sascha_silbe):

 Replying to [comment:6 tomeu]:
 > In any case, it would be journal,
 Good point. I only thought about the git repo it lives in, but you're
 right there's a separate component in Trac for this part of the code.

 > though I don't fully understand why we have only one ticket and not two
 if the idea is that something is wrong in the DS *and* we want the journal
 to be more tolerant to bad data coming from the DS.
 Because we don't know yet if the data store is to blame. It could very
 well have been an activity that wrote the invalid mtime property, in which
 case there probably is nothing else to fix (because it most likely was an
 ancient version and has long been fixed)..

 Replying to [comment:7 alsroot]:
 > I've checked ds and sugar sources, except attached patch there are no
 other not-try-excepted time.strptime calls.

 I would replace the %s with %r so any special characters get escaped and
 the string gets quoted, but other than that the patch looks obviously fine
 (haven't tested it).

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2208#comment:8>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system