[Bugs] #2143 UNSP: add spiral to home view

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Wed Aug 25 05:23:59 EDT 2010

#2143: add spiral to home view
    Reporter:  walter                     |          Owner:  tomeu      
        Type:  enhancement                |         Status:  reopened   
    Priority:  Unspecified by Maintainer  |      Milestone:  0.90       
   Component:  sugar                      |        Version:  Unspecified
    Severity:  Unspecified                |     Resolution:             
    Keywords:  r!                         |   Distribution:  Unspecified
Status_field:  Unconfirmed                |  
Changes (by tomeu):

  * keywords:  r? => r!


 >         if self.key == 'ring-layout':

 This has a very bad smell (http://en.wikipedia.org/wiki/Code_smell). The
 inheritance hierarchy should take care of this, I see two ways to fix this

 * Have a SpiralRingLayout that inherits from RingLayout,
 * Have a SpiralRingLayout that delegates the actual icon placing to
 RingLayout or SpiralLayout based on the number of icons and the available

 Kudos for splitting the patch, but would have been better to leave this
 ticket closed and open a new one instead.

 Also, I don't think the UI freeze really affects these patches.

Ticket URL: <http://bugs.sugarlabs.org/ticket/2143#comment:18>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system

More information about the Bugs mailing list