[Bugs] #1673 HIGH: discard network history does nothing

[Sugar Labs Bugs]

#1673: discard network history does nothing
-----------------------+----------------------------------------------------
    Reporter:  quozl   |          Owner:  tomeu            
        Type:  defect  |         Status:  new              
    Priority:  High    |      Milestone:  0.88.x           
   Component:  sugar   |        Version:  Git as of bugdate
    Severity:  Minor   |       Keywords:  r!               
Distribution:          |   Status_field:  New              
-----------------------+----------------------------------------------------

Comment(by bernie):

 Replying to [comment:18 quozl]:

 > Regarding a split point ... I agree that the split described by Tomeu is
 one option, but I don't see why it is the best option.  The unsplit patch
 was fully tested, and the 0.84 unsplit variant of the patch has had
 extensive testing in the OLPC XO-1 and XO-1.5 builds.

 I don't feel terribly strong for splitting, if it's too much work at this
 point.

 However, I have bad news for you: due to the update_badge() cleanup, your
 patch conflicts with #1610, which has already been landed on master. It
 seems that some rework will be needed anyway.

 In dextrose, the order of these patches is reversed. Here's how I rebased
 #1610 on top of #1673:

 {{{
 @@ -259,15 +268,15 @@ class WirelessNetworkView(CanvasPulsingI
              self.props.base_color = self._color

      def _update_badge(self):
 -        if network.find_connection_by_ssid(self._name) is not None:
 -            self.props.badge_name = "emblem-favorite"
 -            self._palette_icon.props.badge_name = "emblem-favorite"
 -        elif self._flags == network.NM_802_11_AP_FLAGS_PRIVACY:
 -            self.props.badge_name = "emblem-locked"
 -            self._palette_icon.props.badge_name = "emblem-locked"
 -        else:
 -            self.props.badge_name = None
 -            self._palette_icon.props.badge_name = None
 +        self.props.badge_name = None
 +        self._palette_icon.props.badge_name = None
 +        if self._mode != network.NM_802_11_MODE_ADHOC:
 +            if network.find_connection_by_ssid(self._name) is not None:
 +                self.props.badge_name = "emblem-favorite"
 +                self._palette_icon.props.badge_name = "emblem-favorite"
 +            elif self._flags == network.NM_802_11_AP_FLAGS_PRIVACY:
 +                self.props.badge_name = "emblem-locked"
 +                self._palette_icon.props.badge_name = "emblem-locked"

      def _disconnect_activate_cb(self, item):
          connection = network.find_connection_by_ssid(self._name)
 }}}

 Sounds sane?


 > Are there any further suggestions?  The new activity on this ticket is
 very encouraging.  I guess it is because the 0.88 deployments are
 affected?

 Yes, we'd like to have this in Uruguay.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1673#comment:19>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system