[Bugs] #1673 HIGH: discard network history does nothing
Sugar Labs Bugs
bugtracker-noreply at sugarlabs.org
Mon Aug 23 13:54:01 EDT 2010
#1673: discard network history does nothing
-----------------------+----------------------------------------------------
Reporter: quozl | Owner: tomeu
Type: defect | Status: new
Priority: High | Milestone: 0.88.x
Component: sugar | Version: Git as of bugdate
Severity: Minor | Keywords: r!
Distribution: | Status_field: New
-----------------------+----------------------------------------------------
Changes (by tomeu):
* keywords: r? => r!
Comment:
Replying to [comment:13 quozl]:
> Replying to [comment:11 tomeu]:
> > These seem like should be private? (leading underscore)
>
> Fixed.
>
> > Shouldn't we use get_settings() so we can be sure _nm_settings has
been initialized without having to read too much code?
>
> Fixed.
>
> > This patch is r+'ed based the above petty issues are addressed, but
please split it up in several commits, so we have one commit message per
discrete change.
>
> I was unable to determine a suitable split point.
Let me suggest some:
* use the constant dbus.PROPERTIES_IFACE instead of a literal
* implement clearing the networks history
* implement disconnecting from a network
* set the autoconnect flag to False when disconnecting from a network
Are you aware of the importance of not conflating several unrelated issues
in the same commit?
> Replying to [comment:12 tomeu]:
> > ... the code in _disconnect_activate_cb makes several dbus sync calls
...
>
> So does the existing code, in many places. My patch does not and is not
intended to address this existing design issue.
I doubt you will find in Sugar a loop with 3 sync calls inside like the
one your patch introduces.
> I could not find this dbus sync issue described in any other ticket.
I had a conversation with you some months ago about this and you seemed to
agree.
--
Ticket URL: <http://bugs.sugarlabs.org/ticket/1673#comment:16>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system
More information about the Bugs
mailing list