[Bugs] #1759 UNSP: 3G Support: show connection errors

[Sugar Labs Bugs]

#1759: 3G Support: show connection errors
------------------------------------------+---------------------------------
    Reporter:  Dcastelo                   |          Owner:  Dcastelo           
        Type:  defect                     |         Status:  new                
    Priority:  Unspecified by Maintainer  |      Milestone:  0.88.x             
   Component:  sugar                      |        Version:  Git as of bugdate  
    Severity:  Major                      |       Keywords:  3G GSM modem usb r!
Distribution:  Unspecified                |   Status_field:  New                
------------------------------------------+---------------------------------
Changes (by tomeu):

  * keywords:  3G GSM modem usb r? => 3G GSM modem usb r!


Comment:

 Simon, thanks for correcting the flag.

 I think this patch is pretty much ready for merging, with these comments:

 - please run pylint
 - initializing NM_DEVICE_STATE_REASON_DESCRIPTION like in the patch means
 calling gettext several times at startup. Better do it lazily as needed.

 > +        if (connection_time is not None):
 > +            self.props.secondary_text = _('Connected for ' + \
 > +
 connection_time.strftime('%H:%M:%S'))
 > +        else:
 > +            self.props.secondary_text = _('Connected for ' \
 > +                                          + '00:00:00')

 This won't get you the strings translated, try instead:

 _('Connected for %s') % connection_time.strftime('%H:%M:%S')

 A TRANS comment may be needed for translators to know better what they
 have to translate.

 Remember that today is UI freeze.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1759#comment:11>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system