[Bugs] #2006 UNSP: add touchpad section to Sugar CP

[Sugar Labs Bugs]

#2006: add touchpad section to Sugar CP
------------------------------------------+---------------------------------
    Reporter:  walter                     |          Owner:  tomeu      
        Type:  enhancement                |         Status:  new        
    Priority:  Unspecified by Maintainer  |      Milestone:  0.90       
   Component:  sugar                      |        Version:  Unspecified
    Severity:  Unspecified                |       Keywords:  r+         
Distribution:  OLPC                       |   Status_field:  Unconfirmed
------------------------------------------+---------------------------------
Changes (by tomeu):

  * keywords:  r? => r+


Comment:

 > +               TOUCHPAD_MODES[1]: _('stylus')}

 I guess s/TOUCHPAD_MODES[1]/TOUCHPAD_MODE_RESISTIVE ?

 > +        """ Toggle the touchpad mode; called by touchpad icon
 > +        button-release-event handler. """

 I think we shouldn't be so specific about who calls what because otherwise
 we are going to end up with unsync'ed docstrings, specially for public
 methods.

 > +        # Set the initial touchpad device value to capacitive mode
 (finger)
 > +        _write_touchpad_mode(TOUCHPAD_MODE_CAPACITIVE)

 Isn't this comment redundant? Once you get the intent of your code to be
 clear, you don't need inline comments any more ;)

 Please push with this changes, thanks!

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2006#comment:35>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system