[Bugs] #2143 UNSP: add spiral to home view

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Sun Aug 15 11:49:44 EDT 2010


#2143: add spiral to home view
------------------------------------------+---------------------------------
    Reporter:  walter                     |          Owner:  tomeu                      
        Type:  enhancement                |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar                      |        Version:  Unspecified                
    Severity:  Unspecified                |       Keywords:  r!                         
Distribution:  Unspecified                |   Status_field:  Unconfirmed                
------------------------------------------+---------------------------------
Changes (by tomeu):

  * keywords:  r? => r!


Comment:

 Have you considered having separate layouts for the circle and the spiral?
 I suspect the code would end up simpler.

 > +        self._orientation = math.pi

 This seems to be the radius of the icon currently being laid out. Would be
 better if we didn't stored in the object intermediate values used in the
 layout algorithm because any exception raised (broken icon file?) during
 layout would mean it remains broken.

 Please consider calculating the radius of an item from its position in the
 list, or propagating these values in the functions that intervene in the
 layout, probably in a separate class.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2143#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list