[Bugs] #1592 UNSP: NEW FEATURE: enhanced color selector

[Sugar Labs Bugs]

#1592: NEW FEATURE: enhanced color selector
------------------------------------------+---------------------------------
    Reporter:  walter                     |          Owner:  tomeu      
        Type:  enhancement                |         Status:  new        
    Priority:  Unspecified by Maintainer  |      Milestone:  0.90       
   Component:  sugar                      |        Version:  Unspecified
    Severity:  Unspecified                |       Keywords:  r!         
Distribution:  Unspecified                |   Status_field:  Assigned   
------------------------------------------+---------------------------------
Changes (by tomeu):

  * keywords:  r? => r!


Comment:

 > +def _get_prev_stroke_color(color):

 Is it really necesary to abbreviate previous?

 > +    """ Return the prev color pair in the list that shares the same
 fill

 Any reasons for using abbreviations in docstrings?

 > +    for index in range(0, len(colors)):
 > +        if colors[index] == [color.stroke, color.fill]:
 > +            return index

 Use list.index()?

 > +        self._handlers = []

 self._handlers is not used, please drop it.

 > +        for p in sorted(self._pickers.keys()):

 s/p/picker_index?

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1592#comment:31>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system