[Bugs] #1610 NORM: Alternative to Create a new wireless network.

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Thu Aug 12 11:29:05 EDT 2010


#1610: Alternative to Create a new wireless network.
----------------------------+-----------------------------------------------
    Reporter:  reuben       |          Owner:  erikos  
        Type:  enhancement  |         Status:  assigned
    Priority:  Normal       |      Milestone:  0.90    
   Component:  sugar        |        Version:  0.84.x  
    Severity:  Unspecified  |       Keywords:  r?      
Distribution:  Unspecified  |   Status_field:  Assigned
----------------------------+-----------------------------------------------

Comment(by tomeu):

 Replying to [comment:23 erikos]:
 >
 > > {{{
 > > +                        connection.set_connected()
 > > }}}
 > >
 > > connection.connect() may be more in line with the existing code.
 >
 > set_connected is actually a method of NMSettingsConnection
 (model/network.py). Do you mean to change that one?

 Ah, as you prefer.

 > _adhoc_manager_instance = None
 > def get_adhoc_manager_instance():
 >     global _adhoc_manager_instance
 >     if _adhoc_manager_instance is None:
 >         _adhoc_manager_instance = AdHocManager()
 >     return _adhoc_manager_instance
 >
 > get_adhoc_manager_instance is long but get_manager_instance would not be
 descriptive enough imho.

 Some modules have only get_instance() because assume that they will be
 called as members of the module, thus having more context.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1610#comment:25>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list