[Bugs] #1940 UNSP: failed registration breaks registration for the session

[Sugar Labs Bugs]

#1940: failed registration breaks registration for the session
------------------------------------------+---------------------------------
    Reporter:  dsd                        |          Owner:  tomeu                      
        Type:  defect                     |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar                      |        Version:  Unspecified                
    Severity:  Unspecified                |       Keywords:  olpc-0.84 r+               
Distribution:  Unspecified                |   Status_field:  Unconfirmed                
------------------------------------------+---------------------------------
Changes (by tomeu):

  * keywords:  olpc-0.84 r? => olpc-0.84 r+


Comment:

 +            res_init = getattr(libc, '__res_init')

 Here https://bugzilla.redhat.com/show_bug.cgi?id=354071#c9 using
 "res_init" instead of "__res_init" is recommended.

 +            logging.error('Error calling libc.__res_init')

 Better use logging.exception so we get a traceback.

 A bad call through ctypes can cause the whole shell process to crash, so
 please make sure we can be reasonably confident that that won't happen.

 r+ with those concerns addressed, please push.

 For the future, please attach the patch created with git-format-patch and
 in general follow the process in
 http://wiki.sugarlabs.org/go/Development_Team/Code_Review

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1940#comment:15>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system