[Bugs] #1313 UNSP: Activity entry icons in Journal should not be pre-lighting on rollover (fill/stroke colour reverses)

[SugarLabs Bugs]

#1313: Activity entry icons in Journal should not be pre-lighting on rollover
(fill/stroke colour reverses)
------------------------------------------+---------------------------------
    Reporter:  garycmartin                |          Owner:  tomeu            
        Type:  defect                     |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.86             
   Component:  sugar                      |        Version:  Git as of bugdate
    Severity:  Unspecified                |       Keywords:  r?               
Distribution:  Unspecified                |   Status_field:  Unconfirmed      
------------------------------------------+---------------------------------
 When mousing over activity icons in the Journal, their fill and stroke
 colours are being reversed as part of a pre-light icon behaviour. This
 breaks the Sugar ownership colour metaphor for activity entries. Previous
 Sugar releases has no such pre-light roll over behaviour in the Journal so
 I'd class this as a regression.

 The Journal is currently the only place I can see the rollover icon pre-
 lite actually happening. Aleksey pointed me to line 1091 where the stroke
 and fill colours are being reversed for the prelit effect:

 http://git.sugarlabs.org/projects/sugar-
 toolkit/repos/mainline/blobs/master/src/sugar/graphics/icon.py

 {{{
         if self._xo_color is not None:
                     stroke_color = self._xo_color.get_stroke_color()
                     fill_color = self._xo_color.get_fill_color()
                     prelit_fill_color = stroke_color
                     prelit_stroke_color = fill_color
                 else:
                     stroke_color = self._stroke_color
                     fill_color = self._fill_color
                     prelit_fill_color = self._prelit_fill_color
                     prelit_stroke_color = self._prelit_stroke_color
 }}}

 Attached is a small patch to fix the issue.

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/1313>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system