[Bugs] #1262 UNSP: Process non-ds object in the right way in Journal

[SugarLabs Bugs]

#1262: Process non-ds object in the right way in Journal
------------------------------------------+---------------------------------
    Reporter:  alsroot                    |          Owner:  tomeu            
        Type:  defect                     |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.86             
   Component:  sugar                      |        Version:  Git as of bugdate
    Severity:  Unspecified                |     Resolution:                   
    Keywords:  r+                         |   Distribution:  Unspecified      
Status_field:  Unconfirmed                |  
------------------------------------------+---------------------------------
Changes (by tomeu):

  * keywords:  r? => r+


Comment:

 Looks good to me, though I would do:

 {{{
 is_editable = self._query.get('mountpoints', '') == '/'
 self.cell_title.props.editable = is_editable
 }}}

 instead of

 {{{
 315             is_editable = False
 316             mountpoints = self._query.get('mountpoints')
 317             if mountpoints is not None and len(mountpoints):
 318                 is_editable = mountpoints[0] == '/'
 319             self.cell_title.props.editable = is_editable
 }}}

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/1262#comment:6>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system