[Bugs] #1273 UNSP: Bookmark dialog has no border

[SugarLabs Bugs]

#1273: Bookmark dialog has no border
------------------------------------------+---------------------------------
    Reporter:  erikos                     |          Owner:  sayamindu        
        Type:  defect                     |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.86             
   Component:  Read                       |        Version:  Git as of bugdate
    Severity:  Major                      |     Resolution:                   
    Keywords:                             |   Distribution:  Unspecified      
Status_field:  Unconfirmed                |  
------------------------------------------+---------------------------------

Comment(by sayamindu):

 We can't possibly set the dialog window to be fully decorated here, since
 then the close/maximize/minimize buttons will come up. However, I can set
 the window manager to draw frames:

 {{{
 diff --git a/readdialog.py b/readdialog.py
 index c60d1a0..41cafdc 100644
 --- a/readdialog.py
 +++ b/readdialog.py
 @@ -17,7 +17,6 @@ class BaseReadDialog(gtk.Window):

          self.connect('realize', self.__realize_cb)

 -        self.set_decorated(False)
          self.set_position(gtk.WIN_POS_CENTER_ALWAYS)
          self.set_border_width(style.LINE_WIDTH)

 @@ -71,6 +70,7 @@ class BaseReadDialog(gtk.Window):
          self._canvas = canvas

      def __realize_cb(self, widget):
 +        self.window.set_decorations(gtk.gdk.DECOR_BORDER)
          self.window.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_DIALOG)
          self.window.set_accept_focus(True)

 }}}

 Do you think this makes sense ?

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/1273#comment:1>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system