[Bugs] #1586 UNSP: TreeView widget

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Sat Nov 28 00:45:14 EST 2009


#1586: TreeView widget
------------------------------------------+---------------------------------
    Reporter:  alsroot                    |          Owner:  erikos           
        Type:  enhancement                |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.88             
   Component:  sugar-toolkit              |        Version:  Git as of bugdate
    Severity:  Unspecified                |       Keywords:                   
Distribution:  Unspecified                |   Status_field:  Unconfirmed      
------------------------------------------+---------------------------------

Comment(by alsroot):

 Replying to [comment:6 tomeu]:
 > {{{
 >    2625 +COLOR_BACKGROUND = style.COLOR_WHITE
 >    2626 +COLOR_SELECTED = style.COLOR_TEXT_FIELD_GREY
 > }}}
 >
 > Can we make these constants private?

 removed, in former code, it was also used out of this file

 > {{{
 >    2692 +        canvas = hippo.Canvas()
 > }}}
 >
 > Do we really need to use HippoCanvas? I think we should be reducing its
 usage, not increasing it.

 the reason was using CanvasRoundBox

 > {{{
 >    2696 +        sel_box = CanvasRoundBox()
 > }}}
 >
 > Can we avoid that abbr.?

 done

 > {{{
 >    2700 +        cell = cell_class()
 >    2701 +        cell.table = self
 > }}}
 >
 > One more circular reference :(

 removed

 > {{{
 >    2708 +        canvas.table_view_cell_sel_box = sel_box
 >    2709 +        canvas.table_view_cell = cell
 > }}}
 >
 > All class attributes should be set in the constructor, so in this case
 we would need a subclass of hippo.Canvas().

 done

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1586#comment:3>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list