[Bugs] #1550 UNSP: file descriptor leak in filestore.retrieve()

[Sugar Labs Bugs]

#1550: file descriptor leak in filestore.retrieve()
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  sascha_silbe     
        Type:  defect                     |         Status:  accepted         
    Priority:  Unspecified by Maintainer  |      Milestone:  0.88             
   Component:  sugar-datastore            |        Version:  Git as of bugdate
    Severity:  Major                      |       Keywords:  r?               
Distribution:  Unspecified                |   Status_field:  Assigned         
------------------------------------------+---------------------------------
Changes (by sascha_silbe):

  * keywords:  => r?
  * owner:  tomeu => sascha_silbe
  * status:  new => accepted


Comment:

 I've attached two possible fixes, a minimally invasive one and another
 that removes the loop and relies entirely on mkstemp().
 Personally I prefer the second one as it eliminates the possibility of
 triggering bugs on rare occasions (i.e. only if there are already more
 than ten checked-out copies of the entry lying around).

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/1550#comment:1>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system