[Bugs] #569 UNSP: XOIRC error in irc_script.py

[SugarLabs Bugs]

#569: XOIRC error in irc_script.py
------------------------------------------+---------------------------------
    Reporter:  walter                     |          Owner:  mchua                      
        Type:  defect                     |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  Irc                        |        Version:  0.84.x                     
    Severity:  Minor                      |       Keywords:                             
Distribution:  SoaS                       |   Status_field:  Unconfimed                 
------------------------------------------+---------------------------------
 When testing the latest SoaS image, I noticed some error messages in the
 log for XOIRC.



    1.
       Traceback (most recent call last):
    2.
         File "/home/liveuser/Activities/IRC.activity/purk/events.py", line
 44, in trigger
    3.
           f_ref(e_data)
    4.
         File
 "/home/liveuser/Activities/IRC.activity/purk/scripts/theme.py", line 309,
 in onNick
    5.
           window = windows.get(windows.ChannelWindow, e.network, channame)
    6.
       TypeError: get() takes exactly 4 arguments (3 given)
    7.
       Traceback (most recent call last):
    8.
         File "/home/liveuser/Activities/IRC.activity/purk/events.py", line
 44, in trigger
    9.
           f_ref(e_data)
   10.
         File
 "/home/liveuser/Activities/IRC.activity/purk/scripts/irc_script.py", line
 309, in setdownNick
   11.
           window = windows.get(windows.QueryWindow, e.network, e.source)
   12.
       TypeError: get() takes exactly 4 arguments (3 given)




 Tomeu wrote the following patch which seems to fix things.

    1.
       diff --git a/purk/scripts/irc_script.py b/purk/scripts/irc_script.py
    2.
       index 6e38005..a993d2c 100644
    3.
       --- a/purk/scripts/irc_script.py
    4.
       +++ b/purk/scripts/irc_script.py
    5.
       @@ -306,7 +306,7 @@ def onCommandNick(e):
    6.

    7.
        def setdownNick(e):
    8.
            if e.source != e.network.me:
    9.
       -        window = windows.get(windows.QueryWindow, e.network,
 e.source)
   10.
       +        window = windows.get(windows.QueryWindow, e.network,
 e.source, core)
   11.
                if window:
   12.
                    window.id = e.target

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/569>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system