[Bugs] #957 UNSP: Logs do not get updated

[SugarLabs Bugs]

#957: Logs do not get updated
------------------------------------------+---------------------------------
    Reporter:  erikos                     |          Owner:  wadeb 
        Type:  defect                     |         Status:  new   
    Priority:  Unspecified by Maintainer  |      Milestone:  0.86  
   Component:  Log                        |        Version:  0.84.x
    Severity:  Critical                   |       Keywords:        
Distribution:  Unspecified                |   Status_field:  New   
------------------------------------------+---------------------------------
 Solution: Hold a reference to the monitors so they don't get disposed

 {{{
 diff --git a/logviewer.py b/logviewer.py
 index c4e051f..2da0f08 100644
 --- a/logviewer.py
 +++ b/logviewer.py
 @@ -44,6 +44,7 @@ class MultiLogView(gtk.HPaned):

          self.paths = paths
          self.extra_files = extra_files
 +        self._gio_monitors = []

          self.active_log = None
          self.logs = {}
 @@ -145,10 +146,12 @@ class MultiLogView(gtk.HPaned):
          for p in self.paths:
              monitor = gio.File(p).monitor_directory()
              monitor.connect('changed', self._log_file_changed_cb)
 +            self._gio_monitors.append(monitor)

          for f in self.extra_files:
              monitor = gio.File(f).monitor_file()
              monitor.connect('changed', self._log_file_changed_cb)
 +            self._gio_monitors.append(monitor)

      def _log_file_changed_cb(self, monitor, file, other_file, event):
          logfile = file.get_basename()
 }}}

 The pygobject had a change late in the 2.16 cycle why this fix is needed.

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/957>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system