[Bugs] #1090 UNSP: refactor indexing/query parsing, add support for prefixes
SugarLabs Bugs
bugtracker-noreply at sugarlabs.org
Mon Jul 27 06:17:08 EDT 2009
#1090: refactor indexing/query parsing, add support for prefixes
------------------------------------------+---------------------------------
Reporter: sascha_silbe | Owner: tomeu
Type: enhancement | Status: new
Priority: Unspecified by Maintainer | Milestone: Unspecified by Release Team
Component: sugar-datastore | Version: Git as of bugdate
Severity: Unspecified | Resolution:
Keywords: r- | Distribution: Unspecified
Status_field: New |
------------------------------------------+---------------------------------
Changes (by tomeu):
* keywords: r? => r-
Comment:
Do you think would be possible to split this patch in one with the
refactoring and another(s) with the new feature(s)?
Please see the PEP 8 about style, more specifically:
* don't use different coding styles in the same module, much less the same
file.
* favour readability over compactness.
* if you feel the need to add inline comments to make the code more
understandable, consider changing the code structure so it's clearer what
the code does. Splitting a line in two and a function in two is very cheap
in python.
* consider subclassing xapian.TermGenerator and having _index_prop()
there.
* try to avoid using abbreviations in identifiers.
Thanks for the patch, is it related in some way to
http://wiki.sugarlabs.org/go/Features/Plain_Query_Format ?
--
Ticket URL: <http://dev.sugarlabs.org/ticket/1090#comment:2>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system
More information about the Bugs
mailing list