[Bugs] #360 UNSP: Icons for viewsource: Document, Activity Bundle

[SugarLabs Bugs]

#360: Icons for viewsource: Document, Activity Bundle
------------------------------------------+---------------------------------
    Reporter:  erikos                     |          Owner:  eben       
        Type:  defect                     |         Status:  new        
    Priority:  Unspecified by Maintainer  |      Milestone:  0.84       
   Component:  design                     |        Version:  0.83.x     
    Severity:  Blocker                    |     Resolution:             
    Keywords:                             |   Distribution:  Unspecified
Status_field:  New                        |  
------------------------------------------+---------------------------------
Changes (by erikos):

 * cc: tomeu (added)


Comment:

 Replying to [comment:4 garycmartin]:
 > Ooo, interesting ;-)
 >
 > Just a quick sanity check, the 2 tool bar buttons just perform a 'reveal
 tree view column', and a 'hide tree view column'?

 Yes, when we select the document we only display the document (we only
 ever have one). The other view is basically what we find in the activity
 bundle. So we need a way here to select a different files.

 > If so we're really looking for a show/hide file list kinda icon/s. Could
 be a single toggle button with two states, or two radio buttons side by
 side (as you have now), or the more usual way to control a pane like that
 is just use the vertical split view separator handle (7 vertical handle
 dots I see on the view_source.png, but not the view_source_document.png).

 So we have basically two views. One for the bundle and one for the
 document. There are some activities like terminal which only have the
 bundle view - since there is no associated document.

 > Is there performance or other reason for wanting a view_source mode that
 shows both file tree and the selected document, and view_source_document
 mode that just shows the document? One argument would be if there were
 other 'view modes' planned and not just a binary 'show file tree vs. hide
 file tree'.

 I guess/hope I gave the answer already above :)

 > (BTW ... it's great to see the view source concept moving forward!)

 Yeah, all tomeu's work I am just here for nitpicks and cleaning up :)

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/360#comment:5>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system