[Bugs] #916 NORM: Allow sugar on non-XO hardware to register with an XS server

[SugarLabs Bugs]

#916: Allow sugar on non-XO hardware to register with an XS server
-----------------------------+----------------------------------------------
    Reporter:  hamiltonchua  |          Owner:  tomeu                      
        Type:  enhancement   |         Status:  new                        
    Priority:  Normal        |      Milestone:  Unspecified by Release Team
   Component:  sugar         |        Version:  Unspecified                
    Severity:  Unspecified   |     Resolution:                             
    Keywords:  r!            |   Distribution:  Unspecified                
Status_field:  Unconfirmed   |  
-----------------------------+----------------------------------------------

Comment(by tomeu):

 {{{
 +import string
 +import random
 +import time
 +import uuid
 }}}

 These modules are part of the python std lib, please put them in the first
 group. If you could move gconf to a second group, would be great.

 {{{
 +def generate_mfgdata_sn():
 }}}

 mfgdata is an OLPC specific term and sn is an abbreviation that will
 confuse the casual reader, what about generate_serial_number()?

 > This def generates a serial number based on 3 random uppercase letters
 and the last 8 digits of the current unix seconds.

 This probably belongs the API docs, not to this ticket.

 {{{
 +def generate_mfgdata_uuid():
 }}}

 I don't see with what this is consistent with, please remove the function.

 {{{
 +def store_mfgdata(sn, uuid, backup_url):
 }}}

 sn is an abbreviation that can mean several things, please use
 serial_number instead. Uuid is also an abbreviation but has become an
 accepted term of itself and would be really long to write the
 unabbreviated form.

 {{{
 +    backupurl_file = open(os.path.join(identifier_path,
 'backup_url'),'w')
 }}}

 Separate words with _ for all identifiers.

 Please check that you have spaces around operators and after commas.

 Also, please run pylint and pep8.py and fix any messages, if in trouble
 ask in #sugar.

 > I'm not sure what "r!" means in the Keywords field. I'm leaving it as
 is.

 Is meant to remove the ticket from the review queue, please set it to r?
 when you want another review. Have updated the wiki:

 http://wiki.sugarlabs.org/go/Development_Team/Code_Review#Discussion

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/916#comment:27>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system