[Bugs] #976 UNSP: favoritesview.py: icon-color KeyError

[SugarLabs Bugs]

#976: favoritesview.py: icon-color KeyError
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  tomeu            
        Type:  defect                     |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.86             
   Component:  sugar                      |        Version:  Git as of bugdate
    Severity:  Major                      |     Resolution:                   
    Keywords:                             |   Distribution:  Unspecified      
Status_field:  Unconfirmed                |  
------------------------------------------+---------------------------------
Changes (by tomeu):

 * cc: eben, garycmartin (added)


Old description:

> {{{
> Traceback (most recent call last):
>   File "/usr/lib/pymodules/python2.5/dbus/connection.py", line 578, in
> msg_reply_handler
>     reply_handler(*message.get_args_list(**get_args_opts))
>   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
> packages/jarabe/desktop/favoritesview.py", line 383, in <lambda>
>     entries, total_count, callback_cb)
>   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
> packages/jarabe/desktop/favoritesview.py", line 394, in
> __reply_handler_cb
>     callback_cb(entries)
>   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
> packages/jarabe/desktop/favoritesview.py", line 458, in
> __get_last_activity_async_cb
>     self._update()
>   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
> packages/jarabe/desktop/favoritesview.py", line 467, in _update
>     self.props.xo_color = XoColor(first_entry['icon-color'])
> KeyError: 'icon-color'
> }}}
>

> This probably was the cause for
> a) this system disappearing from the neighborhood/group view of another
> system and
> b) the (own) buddy icon on neighborhood view (but not group view) not
> reacting to right click anymore.

New description:

 {{{
 Traceback (most recent call last):
   File "/usr/lib/pymodules/python2.5/dbus/connection.py", line 578, in
 msg_reply_handler
     reply_handler(*message.get_args_list(**get_args_opts))
   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
 packages/jarabe/desktop/favoritesview.py", line 383, in <lambda>
     entries, total_count, callback_cb)
   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
 packages/jarabe/desktop/favoritesview.py", line 394, in __reply_handler_cb
     callback_cb(entries)
   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
 packages/jarabe/desktop/favoritesview.py", line 458, in
 __get_last_activity_async_cb
     self._update()
   File "/home/sascha.silbe/sugar-jhbuild/install/lib/python2.5/site-
 packages/jarabe/desktop/favoritesview.py", line 467, in _update
     self.props.xo_color = XoColor(first_entry['icon-color'])
 KeyError: 'icon-color'
 }}}


 This probably was the cause for
 a) this system disappearing from the neighborhood/group view of another
 system and
 b) the (own) buddy icon on neighborhood view (but not group view) not
 reacting to right click anymore.

--

Comment:

 Replying to [comment:1 sascha_silbe]:
 > This probably happens on an entry imported with copy-to-journal. I might
 also have manually created some metadata (but not icon-color) for the
 entry to be recognized by Turtle Art.
 > Nevertheless the shell shouldn't traceback on a missing color attribute
 (default probably should be the owners colors).

 Agreed, maybe Gary and/or Eben want to comment about what colors to use
 when the metadata property is missing?

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/976#comment:2>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system