[Bugs] #1093 UNSP: "Send to" upload (sender) frame palette can get into a state with no way to dismiss

[SugarLabs Bugs]

#1093: "Send to" upload (sender) frame palette can get into a state with no way to
dismiss
------------------------------------------+---------------------------------
    Reporter:  garycmartin                |          Owner:  garycmartin                
        Type:  defect                     |         Status:  accepted                   
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar                      |        Version:  Git as of bugdate          
    Severity:  Major                      |     Resolution:                             
    Keywords:  r?                         |   Distribution:  Unspecified                
Status_field:  Unconfirmed                |  
------------------------------------------+---------------------------------
Changes (by garycmartin):

  * keywords:  r- => r?
  * owner:  tomeu => garycmartin
  * status:  new => accepted


Comment:

 OK, well let me take another look. I was hoping to keep any changes to a
 bare minimum (due to the pain of testing this, and the time it burns for
 me). Would you consider an even more minimal patch to fix the current bug?
 Unfortunately it provides no user acknowledgement that the remote user
 declined the transfer :-(

 {{{
 diff --git a/src/jarabe/frame/activitiestray.py
 b/src/jarabe/frame/activitiestray.py
 index 1e2b8e8..65b349d 100644
 --- a/src/jarabe/frame/activitiestray.py
 +++ b/src/jarabe/frame/activitiestray.py
 @@ -865,7 +865,8 @@ class OutgoingTransferPalette(BaseTransferPalette):

              self.update_progress()

 -        elif self.file_transfer.props.state ==
 filetransfer.FT_STATE_COMPLETED:
 +        elif self.file_transfer.props.state ==
 filetransfer.FT_STATE_COMPLETED\
 +             or self.file_transfer.props.state ==
 filetransfer.FT_STATE_CANCELLED:

              for item in self.menu.get_children():
                  self.menu.remove(item)
 }}}

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/1093#comment:4>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system