[Bugs] #144 MINO: My Icon: move the menu to the frame

SugarLabs Bugs bugtracker-noreply at sugarlabs.org
Sat Dec 20 14:51:59 EST 2008


#144: My Icon: move the menu to the frame
--------------------------+-------------------------------------------------
  Reporter:  rkabir       |       Owner:  rkabir
      Type:  enhancement  |      Status:  new   
  Priority:  minor        |   Component:  sugar 
Resolution:               |    Keywords:  r?    
--------------------------+-------------------------------------------------

Comment(by tomeu):

 {{{
 +        self._model = SystemModel()
 }}}

 If SystemModel doesn't contain anything relevant, is better to take it out
 completely. Also, we are trying to keep at a minimum the GObject-based
 classes because of memory usage.

 We are not following MVC strictly at all, just found it to be a nice way
 to divide responsibilities in some parts of the shell.

 {{{
 +        self.set_size_request(style.zoom(style.GRID_CELL_SIZE * 2), -1)
 }}}

 Do we really need to set a fixed size? set_size_request can cause layout
 issues in other resolutions.

 {{{
 +    def __popup_cb(self, palette_):
 +        pass
 }}}

 Better to take this out if it's not needed.

 The patch looks great, will push a reviewed version as I think to remember
 that Eben agreed on this during the SugarCamp.

 Thanks!

-- 
Ticket URL: <http://dev.sugarlabs.org/ticket/144#comment:3>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list