[ASLO] Jam2Jam version 3 in sandbox

[thorin kerr]

Thank you for checking this Walter... but... Are you sure you have the
version which is pending review?

The reason being is that I fixed this error, hence the update.

Sure enough when I download version 3 from
http://activities.sugarlabs.org/en-US/sugar/downloads/file/27911/jam2jam-3.xo

Line 39 in Activities/jam2jam.activity/City/Parameters.py reads:
img = pygame.transform.scale(img, int(img.get_width() * scale[0]),
int(img.get_height() * scale[-1]))

note the use of 'int(...)'.



Thorin




On Thu, Mar 22, 2012 at 11:56 AM, Walter Bender <walter.bender at gmail.com> wrote:
> On Wed, Mar 21, 2012 at 9:40 PM, thorin kerr <thorin.kerr at gmail.com> wrote:
>> Dear Activity Library Editors
>>
>> I put through an update to my activity - Jam2Jam - on March the 12th.
>> It's still sitting in the sandbox, pending review file.
>>
>> Could someone kindly review it?
>>
>> My apologies if there is a queue and I should still wait my turn.
>>
>> --------
>>
>> From http://lists.sugarlabs.org/archive/aslo/2012-March/001736.html
>>
>> New version of activity is arrived.
>>
>> Name: Jam2Jam
>> Version Number: 3
>> URL: http://activities.sugarlabs.org/en-US/sugar/addon/4290
>> Review Link: http://activities.sugarlabs.org/en-US/editors/review/30906
>>
>> Regards
>>
>> Thorin Kerr
>> _______________________________________________
>> ASLO mailing list
>> ASLO at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/aslo
>
> I am having trouble with this activity in jhbuild:
>
> File "/home/walter/Activities/jam2jam.activity/City/Parameters.py", line 39, in
> loadImage
>    img = pygame.transform.scale(img, (img.get_width() * scale[0],
> img.get_height() * scale[-1]))
> TypeError: integer argument expected, got float
>
>
> Also, think you could convert your activity to use the new toolbars?
>
> -walter
>
> --
> Walter Bender
> Sugar Labs
> http://www.sugarlabs.org